Merge branch 'master' into 'master'

Update Report-Heloise-CordiClaes-35111900.md

See merge request ldricot/lingi2401!394

projects/projects_2024-25/Report-Heloise-CordiClaes-35111900.md

@@ -6,7 +6,7 @@
 | **Academic Year:**       | 2024-2025                                |
 | **Date:**                | 09/12/2024                  |
 | **Open Source Project:** | [Scribe-iOS](https://github.com/scribe-org/Scribe-iOS)|
-| **Pull request made:**   | [PR#520]|
+| **Pull request made:**   | [PR#524]|
 | **License**              | [ GPL-3.0 license ](https://github.com/scribe-org/Scribe-iOS?tab=GPL-3.0-1-ov-file#readme) |
 
 
@@ -30,16 +30,18 @@ Second I had to make myself comfortable with the swift language that I've never
 
 ### **Choosing the issue**
 As I asked the community to tell me which issue I could contribute to. I was attributed to 2 different issues. The first one was to add some basics tests to test different functionnalities, the second one is to switch all language references in code to ISO-2 codes. 
-I worked first with the first one, that was accepted to be merge. But I'm still working on the second issue. 
+I worked first with the first one PR #520, that an owner told me as fine, but finally there was mistakes in my file, and after few private chat with him, I decided to fully focus on the second issue (#494).
 
 ### **Implementation**
-I've implemented a new file with some tests, using different functionalities as the plural of nouns, or translation.
+So, I've first implemented a new file with some tests, using different functionalities as the plural of nouns, or translation. As I said, that was finally not accepted due to problems with matching the tests and the app.
+I secondly implemented modifications in 15 different files, to switch most of language references to ISO-2 codes, in response to issue #494. For example, I had to change change EnglishVariable into enVariable or FrenchVariable into frVariable, and so on with every variables or functions named with that type. I had then to rearrange and check the calls of theses variables, to see if that was not bringing new bugs or issues.
 
 ## **Lessons learned**
 
 I've learned lot of different things during the project :
 * I learned how to search for an helping contribution.
 * I have new skills now on how to make pull request with a project that I didn't know at first.
+* I developed also my skills with the command line to 'play' with a github repository.
 * Reading thoroughly other pull requests tells what maintainers expect and saves everybody time.
 * Understanding the context of why a license is chosen is essential.