Skip to content
Extraits de code Groupes Projets

Resolve "tests: +sample item"

Tous les fils de conversation ont été résolus !
Fusionnées Delphine van Rossum a demandé de fusionner 138-tests-sample-item vers dev
Tous les fils de conversation ont été résolus !

Closes #138 (closed)

We can now add group with demo set to true in group.csv. (I can mention this in the readme that @bridubois proposed to add for the issue #133 (closed))

DB CHANGES: I added a column demo in the survey_groups table. I had to delete my table to see the new column.

Modification effectuée par Brieuc Dubois

Rapports de requête de fusion

Loading
Loading

Activité

Filtrer l'activité
  • Approbations
  • Assignés et relecteurs
  • Commentaires (des bots)
  • Commentaires (des utilisateurs)
  • Branches et validations
  • Modifications
  • Labels
  • État de verrouillage
  • Mentions
  • État de la demande de fusion
  • Suivi
  • Brieuc Dubois
  • Brieuc Dubois
    • Résolue par Brieuc Dubois

      Thank you overall for the feature, and the fast delivery

      Except a few details I pointed out in the code, I wonder why you check if a group is a demo when requesting the score, rather than just skip sending it's value to the backend and database? As far as I understood, the overall idea is to not store the demo's response?

      PS: FYI I created a new tag, "Breaking changes" to notify that we will have to do some updates of the DB.

      PS2: Adding the comment "Closes #issue" will close the issue mentioned directly when the MR is merged.

      Modifié par Brieuc Dubois
  • Brieuc Dubois changed the description

    changed the description

  • added 1 commit

    • 6104f5e1 - use .id instead of _id and changed if group is not None

    Compare with previous version

  • added 1 commit

    • 0bc4ea94 - skip sending answer if it's a demo group

    Compare with previous version

  • Brieuc Dubois resolved all threads

    resolved all threads

  • Brieuc Dubois approved this merge request

    approved this merge request

  • I just tested it, and it seems really nice! I just wonder if it wouldn't be more logical to have the attribute on the surveys, rather than the groups? @sbibauw

    Modifié par Brieuc Dubois
  • Brieuc Dubois mentioned in merge request !18 (merged)

    mentioned in merge request !18 (merged)

  • Brieuc Dubois added 20 commits

    added 20 commits

    Compare with previous version

  • Brieuc Dubois mentioned in commit 5fd55914

    mentioned in commit 5fd55914

  • Veuillez vous inscrire ou vous connecter pour répondre
    Chargement en cours