Resolve "tests: +sample item"
Closes #138 (closed)
We can now add group with demo set to true in group.csv. (I can mention this in the readme that @bridubois proposed to add for the issue #133 (closed))
DB CHANGES: I added a column demo in the survey_groups table. I had to delete my table to see the new column.
Rapports de requête de fusion
Activité
added Studies & tests To do labels
added Breaking changes label
- Résolue par Delphine van Rossum
- Résolue par Brieuc Dubois
- Résolue par Brieuc Dubois
- Résolue par Brieuc Dubois
Thank you overall for the feature, and the fast delivery
Except a few details I pointed out in the code, I wonder why you check if a group is a demo when requesting the score, rather than just skip sending it's value to the backend and database? As far as I understood, the overall idea is to not store the demo's response?
PS: FYI I created a new tag, "Breaking changes" to notify that we will have to do some updates of the DB.
PS2: Adding the comment "Closes #issue" will close the issue mentioned directly when the MR is merged.
Modifié par Brieuc Dubois
added 1 commit
- 6104f5e1 - use .id instead of _id and changed if group is not None
I just tested it, and it seems really nice! I just wonder if it wouldn't be more logical to have the attribute on the surveys, rather than the groups? @sbibauw
Modifié par Brieuc Duboismentioned in merge request !18 (merged)
added 20 commits
-
0bc4ea94...74db42cb - 19 commits from branch
dev
- 18d3cb77 - Merge branch 'dev' into '138-tests-sample-item'
-
0bc4ea94...74db42cb - 19 commits from branch
mentioned in commit 5fd55914